-
Notifications
You must be signed in to change notification settings - Fork 585
gnupg2: Upgrade gnupg2 to 2.4.7 #14070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we should just to double check, once try a full build (if possible) and boot :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrade GnuPG (gnupg2) from 2.4.4 to 2.4.7 and libgpg-error from 1.47 to 1.48 to resolve an “invalid radix64” error and support the new --gnupgorg
argument in the yat2m tool.
- Bump package versions in toolchain and pkggen_core manifests for both x86_64 and aarch64
- Update
cgmanifest.json
download URLs and versions - Update spec files (
.spec
and.signatures.json
) for libgpg-error and gnupg2, including changelog and symlink additions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
toolkit/resources/manifests/package/toolchain_x86_64.txt | Bump gnupg2 to 2.4.7 and libgpg-error to 1.48 |
toolkit/resources/manifests/package/toolchain_aarch64.txt | Same bumps for aarch64 |
toolkit/resources/manifests/package/pkggen_core_x86_64.txt | Update gnupg2 and libgpg-error versions |
toolkit/resources/manifests/package/pkggen_core_aarch64.txt | Same for aarch64 |
cgmanifest.json | Update download URLs and versions for both libs |
SPECS/libgpg-error/libgpg-error.spec | Version bump to 1.48, update changelog |
SPECS/libgpg-error/libgpg-error.signatures.json | Update tarball signature |
SPECS/gnupg2/gnupg2.spec | Version bump to 2.4.7, update dependencies & symlinks |
SPECS/gnupg2/gnupg2.signatures.json | Update tarball signature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The changes look good. Notably, the symlinks for the man pages are now created before the make install step, which ensures they are properly available. Thanks for handling this!
Initiated a full build here : |
Full build successful |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
With 2.4.4:
During the upgrade of GnuPG to version 2.4.7, a build issue was encountered due to the yat2m tool, which is used for doc generation. The 2.4.7 version of gnupg requires yat2m to support the --gnupgorg argument. However, this argument is not recognized in the version of yat2m provided by libgpg-error 1.47.
To resolve this, the libgpg-error package was upgraded to version 1.48, which includes support for the --gnupgorg option. This allows the gnupg 2.4.7 package to build successfully
Change Log
Does this affect the toolchain?
YES
Associated issues
Links to CVEs
Test Methodology