Skip to content

gnupg2: Upgrade gnupg2 to 2.4.7 #14070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

KavyaSree2610
Copy link
Contributor

@KavyaSree2610 KavyaSree2610 commented Jun 23, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • While attempting to verify a digital signature using gpg --verify with gnupg version 2.4.4, an "invalid radix64" error was encountered. Upgrading to gnupg version 2.4.7 will resolve this issue.

With 2.4.4:

image

  • During the upgrade of GnuPG to version 2.4.7, a build issue was encountered due to the yat2m tool, which is used for doc generation. The 2.4.7 version of gnupg requires yat2m to support the --gnupgorg argument. However, this argument is not recognized in the version of yat2m provided by libgpg-error 1.47.

  • To resolve this, the libgpg-error package was upgraded to version 1.48, which includes support for the --gnupgorg option. This allows the gnupg 2.4.7 package to build successfully

Change Log
  • Upgrade libgpg-error to 1.48 to support gnupg2
  • Upgrade gnupg2 to 2.4.7
Does this affect the toolchain?

YES

Associated issues
Links to CVEs
Test Methodology
  • With 2.4.7:

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jun 23, 2025
@KavyaSree2610 KavyaSree2610 added the stable-release-shiproom PRs for consideration for stable shiproom label Jun 24, 2025
@KavyaSree2610 KavyaSree2610 marked this pull request as ready for review June 24, 2025 05:24
@KavyaSree2610 KavyaSree2610 requested a review from a team as a code owner June 24, 2025 05:24
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should just to double check, once try a full build (if possible) and boot :)

@Kanishk-Bansal Kanishk-Bansal requested a review from Copilot June 24, 2025 06:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrade GnuPG (gnupg2) from 2.4.4 to 2.4.7 and libgpg-error from 1.47 to 1.48 to resolve an “invalid radix64” error and support the new --gnupgorg argument in the yat2m tool.

  • Bump package versions in toolchain and pkggen_core manifests for both x86_64 and aarch64
  • Update cgmanifest.json download URLs and versions
  • Update spec files (.spec and .signatures.json) for libgpg-error and gnupg2, including changelog and symlink additions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
toolkit/resources/manifests/package/toolchain_x86_64.txt Bump gnupg2 to 2.4.7 and libgpg-error to 1.48
toolkit/resources/manifests/package/toolchain_aarch64.txt Same bumps for aarch64
toolkit/resources/manifests/package/pkggen_core_x86_64.txt Update gnupg2 and libgpg-error versions
toolkit/resources/manifests/package/pkggen_core_aarch64.txt Same for aarch64
cgmanifest.json Update download URLs and versions for both libs
SPECS/libgpg-error/libgpg-error.spec Version bump to 1.48, update changelog
SPECS/libgpg-error/libgpg-error.signatures.json Update tarball signature
SPECS/gnupg2/gnupg2.spec Version bump to 2.4.7, update dependencies & symlinks
SPECS/gnupg2/gnupg2.signatures.json Update tarball signature

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The changes look good. Notably, the symlinks for the man pages are now created before the make install step, which ensures they are properly available. Thanks for handling this!

@Kanishk-Bansal
Copy link
Contributor

Buddy Build

Initiated a full build here :
Full Build

@KavyaSree2610
Copy link
Contributor Author

Buddy Build

Initiated a full build here : Full Build

Full build successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging stable-release-shiproom PRs for consideration for stable shiproom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants