-
Notifications
You must be signed in to change notification settings - Fork 586
Upgrade clamav to 1.0.9 to address CVE-2025-20260 [CRITICAL] #14089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade clamav to 1.0.9 to address CVE-2025-20260 [CRITICAL] #14089
Conversation
SPECS/clamav/clamav.spec
Outdated
@@ -11,7 +11,7 @@ Source0: https://github.com/Cisco-Talos/clamav/archive/refs/tags/%{name}- | |||
# Note: the %%{name}-%%{name}-%%{version}-cargo.tar.gz file contains a cache created by capturing the contents downloaded into $CARGO_HOME. | |||
# To update the cache run: | |||
# [repo_root]/toolkit/scripts/build_cargo_cache.sh %%{name}-%%{version}.tar.gz %%{name}-%%{name}-%%{version} | |||
Source1: %{name}-%{version}-cargo.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo file needs to be updated as a part of upgrades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a part of the upgrade, a new tar ball should be created for the closest version and updated. This would reduce nuances in the future. Also, the new version has an additional entry "clamav_rust-0.0.1.crate".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see about Cargo file update
@aaruag, I did see the notes to upgrade -cargo.tar.gz but I didn't find any difference between the crate requirements from 1.0.7 and 1.0.9 versions of clamav hence didn't create additional tarball. If there was an issue, it would have caught in compilation as crate versions are required for compilation. For completion, here are the lists of crates which I got from cargo registry for older version tarball and new version source download.
While the crates from the upstream 1.0.9 cargo.lock file,
All the names and versions are same except a new dependency |
SPECS/clamav/clamav.spec
Outdated
@@ -11,7 +11,7 @@ Source0: https://github.com/Cisco-Talos/clamav/archive/refs/tags/%{name}- | |||
# Note: the %%{name}-%%{name}-%%{version}-cargo.tar.gz file contains a cache created by capturing the contents downloaded into $CARGO_HOME. | |||
# To update the cache run: | |||
# [repo_root]/toolkit/scripts/build_cargo_cache.sh %%{name}-%%{version}.tar.gz %%{name}-%%{name}-%%{version} | |||
Source1: %{name}-%{version}-cargo.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a part of the upgrade, a new tar ball should be created for the closest version and updated. This would reduce nuances in the future. Also, the new version has an additional entry "clamav_rust-0.0.1.crate".
Buddy build after version upgrade of vendor tarball. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Co-authored-by: Kshitiz Godara <kgodara@microsoft.com> Co-authored-by: jslobodzian <joslobo@microsoft.com> (cherry picked from commit f523c2a)
Auto cherry-pick results:
Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=849763&view=results |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Upgrade clamav to 1.0.9 to address CVE-2025-20260
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology