Skip to content

Permit users to type Ctrl^C during ISO installing progress #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Permit users to type Ctrl^C during ISO installing progress #2046

wants to merge 1 commit into from

Conversation

eiffel-fl
Copy link
Contributor

@eiffel-fl eiffel-fl commented Jan 31, 2022 •
edited
Loading

Hi

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Before this PR, users cannot type Ctrl^C to exit the ISO installing progress when the progress bar is printed.
This behavior was thought to avoid users to exit this process by mistake.
I had a problem during which the installation froze so I removed the code handling Ctrl^C from HandleInput() and was once you typed Ctrl^C you are prompted to confirm you want to exit the installation process.

Change Log
  • Remove Ctrl^C from HandleInput to enable users to exit ISO installation process.
Does this affect the toolchain?

NO

Test Methodology
  • I built an ISO with this patch and typed Ctrl^C once the progress bar is printed.
    image

Best regards.

@eiffel-fl
imagegen: disktutils: Permit users to Ctrl^C during ISO installing pr…
979105a 
…ogress.

Before this commit, Ctrl^C was caught by HandleInput() to avoid users exiting
the ISO installing progress by mistake.
Removing this code is OK since if user types Ctrl^C a pop-up asks for
confirmation before exiting the installation process.

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
@eiffel-fl eiffel-fl changed the base branch from 1.0 to main January 31, 2022 17:34
@christopherco christopherco self-requested a review February 12, 2022 03:08
@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherco christopherco Awaiting requested review from christopherco

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eiffel-fl