Skip to content

Use HTTPS source for arpwatch #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamieMagee
Copy link
Member

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

See #3161

Change Log
  • Replace arpwatch FTP source with HTTPS source
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@JamieMagee JamieMagee requested a review from a team as a code owner June 14, 2022 05:24
@ghost ghost added the main PR Destined for main label Jun 14, 2022
Copy link
Contributor

@oliviacrain oliviacrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good- I verified that the file checksum for the new URL is the same as the old one.

One ask- please update cgmanifest.json to reflect this change.

@JamieMagee JamieMagee requested a review from oliviacrain June 17, 2022 21:53
@JamieMagee
Copy link
Member Author

Thanks for the feedback 😄

I updated cgmanifest.json (I really should have seen that coming 🤦 ) and applied the spec lint suggestions too.

@JamieMagee
Copy link
Member Author

@oliviacrain ready for review again 😄


%post
%systemd_post arpwatch.service
%{systemd_post} arpwatch.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter bug- we shouldn't be putting brackets here

-M -r -d %{_vararpwatch} arpwatch 2> /dev/null
fi
:

%postun
%systemd_postun_with_restart arpwatch.service
%{systemd_postun_with_restart} arpwatch.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter bug- we shouldn't be putting brackets here

@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants