-
Notifications
You must be signed in to change notification settings - Fork 583
Use HTTPS source for arpwatch
#3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself looks good- I verified that the file checksum for the new URL is the same as the old one.
One ask- please update cgmanifest.json
to reflect this change.
Thanks for the feedback 😄 I updated |
@oliviacrain ready for review again 😄 |
|
||
%post | ||
%systemd_post arpwatch.service | ||
%{systemd_post} arpwatch.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter bug- we shouldn't be putting brackets here
-M -r -d %{_vararpwatch} arpwatch 2> /dev/null | ||
fi | ||
: | ||
|
||
%postun | ||
%systemd_postun_with_restart arpwatch.service | ||
%{systemd_postun_with_restart} arpwatch.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter bug- we shouldn't be putting brackets here
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/tools/cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
See #3161
Change Log
arpwatch
FTP source with HTTPS sourceDoes this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology