-
Notifications
You must be signed in to change notification settings - Fork 585
Use HTTPS source for aspell
#3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address issues regarding the source tar and confirm that the package builds. Once it works locally, please remember to upload the source tar to our blobstore.
@Camelron I switched back from the GitHub mirror to |
- Switch from FTP to HTTPS source | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Switch from FTP to HTTPS source | |
- Switch from FTP to HTTPS source | |
- License verified | |
Went ahead and took a look at the licensing- seems that everything in this spec is consistent with the source. Once you add this line, I can approve and merge!
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/tools/cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
See #3161
Change Log
aspell
FTP source with HTTPS sourceDoes this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology