Skip to content

Use HTTPS source for aspell #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JamieMagee
Copy link
Member

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

See #3161

Change Log
  • Replace aspell FTP source with HTTPS source
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@JamieMagee JamieMagee requested a review from a team as a code owner June 17, 2022 22:54
@ghost ghost added the main PR Destined for main label Jun 17, 2022
Copy link
Contributor

@Camelron Camelron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address issues regarding the source tar and confirm that the package builds. Once it works locally, please remember to upload the source tar to our blobstore.

@JamieMagee JamieMagee requested a review from Camelron July 2, 2022 00:46
@JamieMagee
Copy link
Member Author

@Camelron I switched back from the GitHub mirror to https://ftp.gnu.org.

Comment on lines +118 to +119
- Switch from FTP to HTTPS source

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Switch from FTP to HTTPS source
- Switch from FTP to HTTPS source
- License verified

Went ahead and took a look at the licensing- seems that everything in this spec is consistent with the source. Once you add this line, I can approve and merge!

@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants