Skip to content

Adding missing binaries for cdi v1.55+ #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Adub17030MS
Copy link
Contributor

@Adub17030MS Adub17030MS commented Jun 19, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This PR is adding the tools/ binaries to rpm spec (these are needed for Nexus GA). The following binaries are required to be included by the Nexus

Change Log
  • Adding tools/ binaries to spec
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jun 19, 2023
@Adub17030MS Adub17030MS marked this pull request as ready for review June 20, 2023 00:47
@Adub17030MS Adub17030MS requested a review from a team as a code owner June 20, 2023 00:47
Comment on lines -158 to +171
%{_bindir}/virt-cdi-apiserver
%{_bindir}/cdi-apiserver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way we're effectively removing the binaries we have already made public and potentially introducing regressions fo whoever has already been using this package. Are we only re-naming the files but they are actually the same executables or are the new ones different from the old ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, would like to see symlinks from the old names to the new.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same binaries, just renames.
We had a bad name to begin with. Those were created mainly for cdi containers so less likely a chance of breaking anyone.

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more details in the summary. Right now it's unclear why we're making this change and in the current state the modifications are a regression, so we should have a good justification.

If we're only re-naming the executables, then please also explain why we're doing that and make sure the old ones are still available to prevent breaking anyone, who might have been using the ones from the previous versions of the package.

@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants