-
Notifications
You must be signed in to change notification settings - Fork 585
Adding missing binaries for cdi v1.55+ #5708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SPECS/containerized-data-importer/containerized-data-importer.spec
Outdated
Show resolved
Hide resolved
SPECS/containerized-data-importer/containerized-data-importer.spec
Outdated
Show resolved
Hide resolved
%{_bindir}/virt-cdi-apiserver | ||
%{_bindir}/cdi-apiserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way we're effectively removing the binaries we have already made public and potentially introducing regressions fo whoever has already been using this package. Are we only re-naming the files but they are actually the same executables or are the new ones different from the old ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, would like to see symlinks from the old names to the new.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same binaries, just renames.
We had a bad name to begin with. Those were created mainly for cdi containers so less likely a chance of breaking anyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more details in the summary. Right now it's unclear why we're making this change and in the current state the modifications are a regression, so we should have a good justification.
If we're only re-naming the executables, then please also explain why we're doing that and make sure the old ones are still available to prevent breaking anyone, who might have been using the ones from the previous versions of the package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
This PR is adding the tools/ binaries to rpm spec (these are needed for Nexus GA). The following binaries are required to be included by the Nexus
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology