Skip to content

Increase crypt rounds to match OWASP guidance #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

richardwhiuk
Copy link

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Increase the number of SHA-512 used for passwords in /etc/shadow to match OWASP guidance in https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2

This increases the number of rounds from 5k to 210k

Change Log

Updates shadow-utils:

* Mon Jul 31 2023 Richard Whitehouse <richard.whitehouse@microsoft.com> - 4.9-13
- Increase SHA-512 rounds to match OWASP guidance
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: xxxx

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please retarget the PR to main instead of 2.0

@richardwhiuk richardwhiuk changed the base branch from 2.0 to main July 31, 2023 09:14
@richardwhiuk richardwhiuk force-pushed the shadow-crypt-rounds branch from 01cded1 to 0fe5ba6 Compare July 31, 2023 09:46
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants