fix: *golang: Set GOROOT_FINAL to use libdir #6388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
golang_libdir
branch
from
b2296a2 to
b80d1b4
Compare
mfrw
reviewed
Oct 11, 2023
GOROOT_FINAL sets the compiled-in default GOROOT for the final go binary. This was set to /usr/bin/go which causes the `go` command to error out (when /etc/profile is not loaded) because that is the binary path not the path of the final GOROOT.
cpuguy83
force-pushed
the
golang_libdir
branch
from
45f6103 to
0d4c2b1
Compare
|
@mfrw done |
|
Any updates on this one? |
Apologies, this got drowned in the numerous notifications from github :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Fix golang packages to set the compiled-in GOROOT correctly.
This is not causing problems under normal circumstances because shells are loading /etc/profile which has the correct GOROOT set.
However the go binary itself has an invalid GOROOT.
GOROOT_FINAL sets the compiled-in default GOROOT for the final go binary.
This was set to /usr/bin/go which causes the
gocommand to error out (when /etc/profile is not loaded) because that is the binary path not the path of the final GOROOT.Change Log
golangandmsft-golangto have the correct final valueDoes this affect the toolchain?
NO
Associated issues
Test Methodology