Make managed exports optional #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Micro PR 🔬
There was a problem hiding this comment.
Pull Request Overview
This PR makes managed exports optional for FinOps hub deployments, allowing users who cannot grant User Access Administrator to disable this functionality. Key changes include:
- Introducing a new boolean parameter (enableManagedExports) in multiple Bicep templates (hub.bicep, dataFactory.bicep, and main.bicep) to control managed exports.
- Wrapping related resources and role assignments in conditionals based on enableManagedExports.
- Updating the UI definition and documentation to reflect the change.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/templates/finops-hub/modules/hub.bicep | Added parameter enableManagedExports and passed it to resource modules. |
| src/templates/finops-hub/modules/dataFactory.bicep | Added parameter enableManagedExports, applied conditional logic to RBAC roles and resources. |
| src/templates/finops-hub/main.bicep | Passed enableManagedExports parameter to the hub module. |
| src/templates/finops-hub/createUiDefinition.json | Updated UI elements to include managed exports settings. |
| docs-mslearn/toolkit/hubs/template.md | Updated documentation to describe the new enableManagedExports parameter. |
| docs-mslearn/toolkit/changelog.md | Added changelog entry for the enableManagedExports feature. |
Comments suppressed due to low confidence (2)
src/templates/finops-hub/createUiDefinition.json:734
- Ensure that the UI definition for 'enableManagedExports' accurately reflects the parameter's purpose and default behavior, matching the implementation in the Bicep modules.
"enableManagedExports": "[steps('advanced').networking.enableManagedExports]",
docs-mslearn/toolkit/hubs/template.md:64
- Clarify in the documentation that the 'User Access Administrator' role is conditionally applied based on the enableManagedExports setting, ensuring consistency with the new behavior.
| [User Access Administrator](/azure/role-based-access-control/built-in-roles#user-access-administrator) | Assigned to Data Factory to manage data in storage. Not applied when **enableManagedExports** is disabled. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
arthurclares
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Make managed exports optional for people who cannot grant User Access Administrator.
Related to #1600
Fixes #1700
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?