Transactions don't support expiration commands

[xangelix]

Describe the bug

Hopefully this isn't duplicate, but I couldn't find anything that would suggest this is an expected error.

Inside a transaction, it appears some commands related to expiry are not known. This is not an issue on redis, causing my tested migration redis->garnet to fail.

Steps to reproduce the bug

> HSET test ak av bk bv
(integer) 2

> HEXPIREAT test 1750899548 FIELDS 1 ak
1) "1"

> HPTTL test FIELDS 1 ak
1) "24796"

> MULTI
"OK"

> HEXPIREAT test 1750899548 FIELDS 1 bk
"ERR unknown command"

Expected behavior

No response

Screenshots

No response

Release version

Garnet 1.0.73 64 bit; standalone mode

IDE

Redis official CLI
fred (redis rust library)

OS version

Docker Alpine (GitHub repo image)

Additional context

No response

[xangelix]

It's not entirely clear to me where this exception is from, but after testing those commands and some others ~30min ago, I noticed at some point this showed up in my garnet log:

12::45::43 crit: Session[0] [172.18.0.1:47620] [010D6126] ProcessMessages threw an exception: Tsavorite.core.TsavoriteException: Lockable method call when BeginLockable has not been called    at Tsavorite.core.ClientSession`8.CheckIsAcquiredLockable[TSessionFunctions](TSessionFunctions sessionFunctions) in /src/libs/storage/Tsavorite/cs/src/core/ClientSession/ClientSession.cs:line 73    at Tsavorite.core.LockableContext`8.Lock[TLockableKey](TLockableKey[] keys, Int32 start, Int32 count) in /src/libs/storage/Tsavorite/cs/src/core/ClientSession/LockableContext.cs:line 242    at Garnet.server.TxnKeyEntries.LockAllKeys() in /src/libs/server/Transaction/TxnKeyEntry.cs:line 132    at Garnet.server.TransactionManager.Run(Boolean internal_txn, Boolean fail_fast_on_lock, TimeSpan lock_timeout) in /src/libs/server/Transaction/TransactionManager.cs:line 362    at Garnet.server.RespServerSession.NetworkEXEC() in /src/libs/server/Transaction/TxnRespCommands.cs:line 72    at Garnet.server.RespServerSession.ProcessMessages() in /src/libs/server/Resp/RespServerSession.cs:line 560    at Garnet.server.RespServerSession.TryConsumeMessages(Byte* reqBuffer, Int32 bytesReceived) in /src/libs/server/Resp/RespServerSession.cs:line 419

[TalZaccai]

@xangelix could you please provide a repro for the latter exception you mentioned? Thanks!

[xangelix]

@xangelix could you please provide a repro for the latter exception you mentioned? Thanks!

I can try doing some similar tests tonight and see if it triggers it again, but unfortunately I do not have a reproduction.
I do know that this exception did not appear immediately after entering the above commands, but happened some time later. I'm not sure if it's even related to this issue/the commands above.

I was testing garnet with 3 different clients, so it definitely came from a redis command issued from one of them:

• the official redis CLI
• redis insight https://github.com/RedisInsight/RedisInsight
• fred https://github.com/aembke/fred.rs

[prvyk]

I was already looking at something similar, so might as well open the #1271 PR now.

Problem is that MULTI/EXEC context sends commands to the TransactionManager and the command list there is rather partial. This doesn't handle the exception though, just the transaction issue.

[TalZaccai]

I was already looking at something similar, so might as well open the #1271 PR now.

Problem is that MULTI/EXEC context sends commands to the TransactionManager and the command list there is rather partial. This doesn't handle the exception though, just the transaction issue.

Ha! I was about to ask you if you'd like to look into this one :) (the feature request, not the exception)