Cluster Test Stability Fixes #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/cluster-test-stability
branch
from
4a6403b to
dca600f
Compare
vazois
force-pushed
the
vazois/cluster-test-stability
branch
2 times, most recently
from
3ae8876 to
1db9294
Compare
vazois
force-pushed
the
vazois/cluster-test-stability
branch
from
3c9096f to
8559874
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves cluster test stability by:
- Adding OS-specific error logging and metadata validation with retries
- Refactoring and simplifying cluster migration tests and utilities
- Exposing a toggle (
useNativeDeviceLinux) for Linux native device usage in tests
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Garnet.test/TestUtils.cs | Added useNativeDeviceLinux parameter to cluster setup |
| test/Garnet.test.cluster/ReplicationTests/ClusterReplicationBaseTests.cs | Refactored primary/replica indexing and extended timeouts |
| test/Garnet.test.cluster/RedirectTests/ClusterSlotVerificationTests.cs | Introduced AssertSlotsNotAssigned and ClusterState helper |
| test/Garnet.test.cluster/RedirectTests/BaseCommand.cs | Updated single‐slot request setup to use MSET |
| test/Garnet.test.cluster/ClusterTestUtils.cs | Enhanced TLS support, new session creation, added failover wait |
| test/Garnet.test.cluster/ClusterTestContext.cs | Propagated useNativeDeviceLinux through instance creation |
| test/Garnet.test.cluster/ClusterMigrateTests.cs | Simplified migrate tests to continuous read/write tasks |
| test/Garnet.test.cluster/ClusterMigrateTLSTests.cs | Adapted TLS migration tests for async continuous model |
| playground/TstRunner/Program.cs | Updated RunTest signature and slicing test cases |
| libs/storage/Tsavorite/.../DeviceLogCommitCheckpointManager.cs | Added Unix strerror fallback for overlapped IO logging |
| libs/cluster/Server/.../ReceiveCheckpointHandler.cs | Added Unix strerror fallback for overlapped IO logging |
| libs/cluster/Server/.../ReplicaSyncSession.cs | Retries checkpoint‐metadata send until success |
| libs/cluster/Server/.../GarnetClusterCheckpointManager.cs | Changed metadata‐read warnings to errors |
| libs/cluster/Server/.../CheckpointStore.cs | Validates metadata at insertion and logs deletion warnings |
| libs/cluster/Server/ClusterUtils.cs | Added Unix strerror fallback for overlapped IO logging |
Comments suppressed due to low confidence (1)
test/Garnet.test.cluster/ClusterTestUtils.cs:2939
- The variable
contextis not defined in this scope. It looks like this method resides inClusterTestUtilsand should directly callGetReplicationInfo,BackOff, and accept theloggerparameter instead of referencing an undefinedcontext.
var infoItem = context.clusterTestUtils.GetReplicationInfo(nodeIndex, [ReplicationInfoItem.LAST_FAILOVER_STATE], logger: context.logger);
libs/cluster/Server/Replication/PrimaryOps/ReplicaSyncSession.cs
Outdated
Show resolved
Hide resolved
vazois
force-pushed
the
vazois/cluster-test-stability
branch
from
43ec73c to
fbc9f24
Compare
vazois
force-pushed
the
vazois/cluster-test-stability
branch
from
fbc9f24 to
0383b53
Compare
TalZaccai
approved these changes
Jul 9, 2025
libs/cluster/Server/Replication/PrimaryOps/ReplicaSyncSession.cs
Outdated
Show resolved
Hide resolved
TalZaccai
approved these changes
Jul 9, 2025
* Updating Azure.Identity version & bumping Garnet version * Empty commit
* Save large System.Linq.Async depedency by implementing FirstAsync ourselves. * Add .ConfgureAwait(false) matching the other calls. --------- Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* ZDIFF of a key against nonexisting keys should return the original contents. ZDIFF 1 zset should return contents of zset. * ZINTERSTORE should return empty array, not WRONGTYPE error, when given nonexsting keys in input. * ZRANGEBYLEX assertion when the minimum was 'larger' than the maximum value in the sorted set. * it's faster to check the BYLEX condition in the assertion.
* enable support for HEXPIRE variants with txn * add txn hexpire test
vazois
force-pushed
the
vazois/cluster-test-stability
branch
from
a3fd5a8 to
2a5c004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc fixes for cluster tests.