Improvement to equals in SQLServerDataTable (#2653)

* Fix equals function

* match other functions a little better

* cleanup

* Fix NPE

* import only needed

---------

Co-authored-by: George Walter Colgrove IV <georgecolgrove@outlook.com>

Author: Ananya2

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java

@@ -17,6 +17,7 @@
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.Objects;
 import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.locks.Lock;
@@ -397,10 +398,10 @@ public boolean equals(Object object) {
                 boolean equalColumnMetadata = columnMetadata.equals(aSQLServerDataTable.columnMetadata);
                 boolean equalColumnNames = columnNames.equals(aSQLServerDataTable.columnNames);
                 boolean equalRowData = compareRows(aSQLServerDataTable.rows);
+                boolean equalTvpName = Objects.equals(tvpName, aSQLServerDataTable.tvpName);
 
                 return (rowCount == aSQLServerDataTable.rowCount && columnCount == aSQLServerDataTable.columnCount
-                        && tvpName == aSQLServerDataTable.tvpName && equalColumnMetadata && equalColumnNames
-                        && equalRowData);
+                        && equalTvpName && equalColumnMetadata && equalColumnNames && equalRowData);
             }
         }
         return false;

src/test/java/com/microsoft/sqlserver/jdbc/tvp/SQLServerDataTableTest.java

@@ -101,6 +101,23 @@ public void testHashCodes() throws SQLServerException {
         assert (!table.equals(tableClone));
     }
 
+    @Test()
+    public void testEqualsTvp() throws SQLServerException {
+        SQLServerDataTable a = new SQLServerDataTable();
+        SQLServerDataTable b = new SQLServerDataTable();
+
+        assert (a.equals(b));
+
+        a.setTvpName("test");
+        b.setTvpName(new String("test"));
+
+        assert (a.equals(b));
+
+        a.setTvpName("test");
+        b.setTvpName(new String("test2"));
+        assert (!a.equals(b));
+    }
+
     private SQLServerDataTable createTable(SQLServerDataColumn a, SQLServerDataColumn b, SQLServerDataColumn c) throws SQLServerException {
         SQLServerDataTable table = new SQLServerDataTable();
         table.addColumnMetadata(a);