Invalid path specified

[Dmole]

Driver version

mssql-jdbc-12.10.0.jre11.jar

Client Operating System

Microsoft Windows [Version 10.0.26100.3775]

JAVA/JVM version

openjdk 21.0.5 2024-10-15 LTS

Tomcat version

10.1.34

Problem description

This is a regression from mssql-jdbc-12.8.1.jre11.jar

Expected behavior

JDBC keeps working when upgraded.

Actual behavior

JDBC stops working when upgraded.

Error message/stack trace

com.microsoft.sqlserver.jdbc.SQLServerException: Invalid path specified: C:/Program%20Files/Tomcat/webapps/ROOT.war*/WEB-INF/lib/mssql-jdbc-12.10.0.jre11.jar.
 at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.getCurrentClassPath(ConfigurableRetryLogic.java:319)
 at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.readFromFile(ConfigurableRetryLogic.java:339)
 at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.setUpStatementRules(ConfigurableRetryLogic.java:207)
 at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.<init>(ConfigurableRetryLogic.java:89)
 at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.getInstance(ConfigurableRetryLogic.java:106
 at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectInternal(SQLServerConnection.java:2600)
 at com.microsoft.sqlserver.jdbc.SQLServerConnection.connect(SQLServerConnection.java:2207)
 at com.microsoft.sqlserver.jdbc.SQLServerDriver.connect(SQLServerDriver.java:1320)
 at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:681)
 at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:229)

Any other details that can be helpful

Note the "*".
This is only an issue when server.xml has

<Host unpackWARs="false" ....

[ivy-cst]

Same here. Looks like it is only a problem if the path where the mssql-jdbc.jar lives contains a space.

For me it looks like this is a duplicate of #2646

com.microsoft.sqlserver.jdbc.SQLServerException: Invalid URL specified: /C:/Program Files/XYZ/lib/mssql-jdbc.jar.
	at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.getCurrentClassPath(ConfigurableRetryLogic.java:323)
	at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.readFromFile(ConfigurableRetryLogic.java:339)
	at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.setUpStatementRules(ConfigurableRetryLogic.java:207)
	at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.<init>(ConfigurableRetryLogic.java:89)
	at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.getInstance(ConfigurableRetryLogic.java:106)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectInternal(SQLServerConnection.java:2600)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.connect(SQLServerConnection.java:2207)
	at com.microsoft.sqlserver.jdbc.SQLServerDriver.connect(SQLServerDriver.java:1320)
	at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:683)
	at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:191)

[Dmole]

@Jeffery-Wasty @machavan @divang please do some testing as it looks like #2579 breaks common use cases (Tomcat, Wildfly, things in Program Files, or using a JAR/WAR).

It would be best for review if in the future separate PRs were used for format and function changes, and try to limit to one commit per PR.

[machavan]

@Dmole Can you check this PR #2650 and confirm if this addresses the use cases you mentioned?

[siggemannen]

I've used jdbc and java for many years, and it feels like the whole ConfigurableRetryLogic solution is kinda dodgy. There's very little need to growel around in classpaths and files for code which deals with config changes. Why not just have a single connection property containing full path to a file which can be constructed without doing all that work inside ConfigurableRetryLogic#getCurrentClassPath (which also have a interesting name, since it actually returns something other than currentclasspath). Is it to handle bundled jars somehow? Then it's usually enough to do getClass().getResourcesAsStream?

[machavan]

Hi @siggemannen This feature functionality of ConfigurableRetryLogic was introduced as part of #2396

There were some issues addressed with respect to handling of classpath recently.

The latest PR #2650 addresses the issue of exceptions thrown by getCurrentClassPath.

[Dmole]

@machavan

Yes:

• 12.10 fails
• 12.10 + 1ab5f7c works.

[machavan]

Thank you @Dmole for the confirmation, closing this issue.

[ecki]

Cagree that config detector based on the classpath does not look like it fits the rest of the config (and also does not work in many cases where I want config files somewhere Else)

[Dmole]

@machavan When can we expect a 12.10.1 build to resolve this issue?

[muskan124947]

The milestone is added as 12.11.0 in the PR #2650