Improvement to equals in SQLServerDataTable #2620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java
Outdated
Show resolved
Hide resolved
machavan
previously approved these changes
Apr 29, 2025
Ananya2
force-pushed
the
fix/fix-equals-with-string
branch
from
029eeaa to
27bedb9
Compare
David-Engel
previously approved these changes
May 7, 2025
divang
previously approved these changes
May 8, 2025
…lated issues (microsoft#2650) * Addressed-Cannot use mssql-jdbc 12.10 on WildFly if WildFly directory path contains a space * Add general exception * Updated logging level
…crosoft#2638) * Invalidate existing enclave session in during (re)connect * Added check on logging level * Added a speculative fix to invalidate enclaveCache on error 33195 * Moved error checking in PreparedStatement doExecute methods * Added trade for invalidation * Directly call invalidateEnclaveSessionCache from reconnect
…#2652) * correct processing of OffsetDateTime in SQLServerDataTable * add a column to SQLServerDataTableTest with Types.TIMESTAMP_WITH_TIMEZONE and a OffsetDateTime value * added comment --------- Co-authored-by: Leos Bitto <Leos.Bitto@gmail.com>
…inGlac1er/mssql-jdbc into fix/fix-equals-with-string
Ananya2
dismissed stale reviews from divang, David-Engel, and machavan
via
549301f
|
Not sure what happen but somehow my MR is starting to add stuff that I didn't add |
|
I will recreate my MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that it was using == on strings in the equals function for SQLServerDataTable. (I didn't experience a bug as a result of it) Is it intended to check the memory location?