Invalidate existing enclave session during connection (re)connect #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
============================================
+ Coverage 51.63% 51.64% +0.01%
+ Complexity 4014 4008 -6
============================================
Files 147 147
Lines 33762 33772 +10
Branches 5641 5644 +3
============================================
+ Hits 17432 17442 +10
+ Misses 13893 13869 -24
- Partials 2437 2461 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Apr 28, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
David-Engel
previously approved these changes
Apr 28, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerException.java
Outdated
Show resolved
Hide resolved
David-Engel
approved these changes
May 7, 2025
divang
approved these changes
May 8, 2025
github-project-automation
bot
moved this from In progress
to Closed/Merged PRs
in MSSQL JDBC
divang
pushed a commit
that referenced
this pull request
Jun 13, 2025
) * Invalidate existing enclave session in during (re)connect * Added check on logging level * Added a speculative fix to invalidate enclaveCache on error 33195 * Moved error checking in PreparedStatement doExecute methods * Added trade for invalidation * Directly call invalidateEnclaveSessionCache from reconnect
divang
pushed a commit
that referenced
this pull request
Jun 13, 2025
) * Invalidate existing enclave session in during (re)connect * Added check on logging level * Added a speculative fix to invalidate enclaveCache on error 33195 * Moved error checking in PreparedStatement doExecute methods * Added trade for invalidation * Directly call invalidateEnclaveSessionCache from reconnect
divang
added a commit
that referenced
this pull request
Jun 13, 2025
) (#2680) * Invalidate existing enclave session in during (re)connect * Added check on logging level * Added a speculative fix to invalidate enclaveCache on error 33195 * Moved error checking in PreparedStatement doExecute methods * Added trade for invalidation * Directly call invalidateEnclaveSessionCache from reconnect Co-authored-by: Mahendra Chavan <machavan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For AE with secure enclave, the driver connections receives an error 33195 - Internal enclave error. Enclave was provided with an invalid session handle. For more information, contact Customer Support Services, post failovers ( in case of Always On setup).
This could be happening because of driver using existing enclave session from the enclaveCache in the driver.
This fix invalidates the existing enclave session as part of the connect method.