Update readFromFile() in ConfigurableRetryLogic to handle filePath related issues #2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… path contains a space
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
============================================
+ Coverage 51.63% 51.65% +0.02%
- Complexity 4003 4015 +12
============================================
Files 147 147
Lines 33757 33769 +12
Branches 5639 5643 +4
============================================
+ Hits 17429 17445 +16
- Misses 13871 13875 +4
+ Partials 2457 2449 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
David-Engel
previously approved these changes
Apr 23, 2025
tlopesPT
reviewed
Apr 24, 2025
machavan
approved these changes
Apr 28, 2025
machavan
previously approved these changes
Apr 30, 2025
David-Engel
reviewed
May 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
machavan
approved these changes
May 8, 2025
divang
approved these changes
May 8, 2025
Closed
Closed
divang
pushed a commit
that referenced
this pull request
Jun 13, 2025
…lated issues (#2650) * Addressed-Cannot use mssql-jdbc 12.10 on WildFly if WildFly directory path contains a space * Add general exception * Updated logging level
divang
pushed a commit
that referenced
this pull request
Jun 13, 2025
…lated issues (#2650) * Addressed-Cannot use mssql-jdbc 12.10 on WildFly if WildFly directory path contains a space * Add general exception * Updated logging level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github issue -> #2646