Skip to content

Improvement to equals in SQLServerDataTable #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025
Merged

Conversation

Ananya2
Copy link
Contributor

@Ananya2 Ananya2 commented May 6, 2025

Noticed that it was using == on strings in the equals function for SQLServerDataTable. (I didn't experience a bug as a result of it) Is it intended to check the memory location?

@Ananya2
Copy link
Contributor Author

Ananya2 commented May 6, 2025

ADO run:

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.57%. Comparing base (2216f11) to head (6534d58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2653      +/-   ##
============================================
- Coverage     51.75%   51.57%   -0.18%     
+ Complexity     4050     4004      -46     
============================================
  Files           147      147              
  Lines         33781    33782       +1     
  Branches       5647     5647              
============================================
- Hits          17482    17424      -58     
- Misses        13880    13901      +21     
- Partials       2419     2457      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CaptainGlac1er
Copy link
Contributor

Should I close #2620 then?

machavan
machavan previously approved these changes May 8, 2025
divang
divang previously approved these changes May 8, 2025
@Ananya2 Ananya2 dismissed stale reviews from divang and machavan via 6534d58 May 8, 2025 12:42
@Ananya2 Ananya2 added this to the 12.11.0 milestone May 12, 2025
@machavan machavan merged commit be204cb into main May 12, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants