Skip to content

Increased the max noOfRedirections and updated the message. #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

divang
Copy link
Contributor

@divang divang commented May 9, 2025

Details (copied from above issue)

Fabric has introduced a feature that can cause clients to be redirected more than once. The JDBC driver currently limits connections to one redirection.

Describe the preferred solution
M.D.SqlClient has increased their limit to 10 redirections. Other drivers should follow suit and not error until redirection attempts exceed 10.

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.64%. Comparing base (2216f11) to head (85a748a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2659      +/-   ##
============================================
- Coverage     51.75%   51.64%   -0.11%     
+ Complexity     4050     4011      -39     
============================================
  Files           147      147              
  Lines         33781    33783       +2     
  Branches       5647     5647              
============================================
- Hits          17482    17447      -35     
+ Misses        13880    13878       -2     
- Partials       2419     2458      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@David-Engel David-Engel added this to the 12.11.0 milestone May 9, 2025
@divang
Copy link
Contributor Author

divang commented May 12, 2025

ADO run is successful.

@machavan machavan merged commit f0706ea into main May 13, 2025
17 of 19 checks passed
@machavan machavan linked an issue May 14, 2025 that may be closed by this pull request
@divang divang deleted the user/divang/increase_noOfRedirections branch June 11, 2025 06:20
divang added a commit that referenced this pull request Jun 13, 2025
Co-authored-by: Divang Sharma <divangsharma@microsoft.com>
divang added a commit that referenced this pull request Jun 13, 2025
Co-authored-by: Divang Sharma <divangsharma@microsoft.com>
divang added a commit that referenced this pull request Jun 13, 2025
…2682)

Co-authored-by: Divang Sharma <divangsharma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow up to 10 redirections per connection
3 participants