Skip to content

fix tab navigation in side docs #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025
Merged

fix tab navigation in side docs #10677

merged 4 commits into from
Jun 24, 2025

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Jun 20, 2025

fixes microsoft/pxt-microbit#6330

this pr fixes a few side docs tab navigation bugs

  • the "go back" button wasn't tab navigable. it now has a tabindex and was converted to an <a> element
  • the pop-out button was at the end of the tab order in the side docs. it's now the first element in the order
  • the rendered SVG blocks still had the tabindex attribute on some elements

@riknoll riknoll requested a review from a team June 20, 2025 00:07
@srietkerk
Copy link
Contributor

What pop-out button are you referring to? Is it this one?
image
It's first in the tab order for me in beta and live when I open the help docs. Or did adding the a tag mess with things?

@riknoll
Copy link
Member Author

riknoll commented Jun 24, 2025

@srietkerk no, the one that appears in the top-right of the side docs and opens the page in a new tab

@riknoll riknoll enabled auto-merge (squash) June 24, 2025 16:50
@riknoll riknoll merged commit 39861d9 into master Jun 24, 2025
20 checks passed
@riknoll riknoll deleted the dev/riknoll/side-docs-go-back branch June 24, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab navigation for "Go Back" in Side docs
3 participants