volume for sound expressions in simulator #10678
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates sound expression functionality to support a volume parameter, enhancing the simulator sound playback. The key changes include:
- Adding a volume property to the PendingSound interface and propagating the volume parameter in sound playback functions.
- Updating calls to playSoundExpressionAsync in the SoundEffectEditor and SoundGallery components to include a default volume of 127.
- Modifying the playSoundExpressionAsync API signature and related internal logic to account for volume.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/src/components/soundEffectEditor/SoundGallery.tsx | Updated playSoundExpressionAsync call to pass default volume |
| webapp/src/components/soundEffectEditor/SoundEffectEditor.tsx | Updated playSoundExpressionAsync call to pass default volume |
| pxtsim/sound/soundexpression.ts | Extended PendingSound interface and updated internal sound playback logic |
Comments suppressed due to low confidence (1)
pxtsim/sound/soundexpression.ts:289
- To ensure consistent behavior and avoid potential issues when volume is not provided, consider making the volume parameter required or supplying a default value within the function.
export function playSoundExpressionAsync(notes: string, volume?: number, isCancelled?: () => boolean, onPull?: (freq: number, volume: number) => void) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#5193
This pull request introduces support for specifying volume in sound expressions. The changes primarily focus on updating the
playSoundExpressionAsyncand related methods to include avolumeparameter, and ensuring compatibility with existing components that utilize these methods.Enhancements to sound expression functionality:
pxtsim/sound/soundexpression.ts: Added avolumeproperty to thePendingSoundinterface and updated the__playSoundExpressionandplaySoundExpressionAsyncmethods to accept avolumeparameter. Adjusted the internal logic to pass thevolumevalue through the sound playback pipeline. [1] [2] [3] [4] [5]Updates to components using sound expressions:
webapp/src/components/soundEffectEditor/SoundEffectEditor.tsx: Updated the call toplaySoundExpressionAsyncto include a default volume value of127.webapp/src/components/soundEffectEditor/SoundGallery.tsx: Modified the call toplaySoundExpressionAsyncto include a default volume value of127.