Skip to content

Add arm64 build support using the build script #18946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamespack
Copy link
Contributor

@jamespack jamespack commented May 25, 2025

Summary of the Pull Request

Enable build support for ARM64 in the build script

References and Relevant Issues

NONE

Detailed Description of the Pull Request / Additional comments

ARM64 is becoming more prevalent, and terminal should be the first tool we reach for on that platform as well. This pull request lights up build support on ARM64 in the build script.

Validation Steps Performed

it built successfully following the documentation on my Snapdragon Surface Laptop :)

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I plumb forgot this tool existed. We have been ARM64-ready since day one, just so long as you're building inside visual studio. Even our CI doesn't use this module...

That said, we should of course fix this :p

@jamespack jamespack changed the title Add arm64 build support Add arm64 build support using the build script May 25, 2025
@jamespack
Copy link
Contributor Author

Added clarity to where exactly this adds support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants