Setting to set pane highlight active, inactive and broadcast color

[Techypanda]

Summary of the Pull Request

This commit adds a new setting in which you can configure the active highlight color of panes as well as inactive and broadcast. This will only happen if configured otherwise uses the default as suggested by #3061

References and Relevant Issues

#3061

Detailed Description of the Pull Request / Additional comments

When modifying the settings you can now set pane key to have the following properties:

• "activeBorderColor"
• "inactiveBorderColor"
• "broadcastBorderColor"
  This allows for more configuration of the windows terminal

Validation Steps Performed

Built Locally, Ran Locally and configured a profile with the following theme:

"themes": 
[
    {
        "name": "Under Construction",
        "tab": {
            "background": "#FFFF00FF",
            "iconStyle": "default",
            "showCloseButton": "always",
            "unfocusedBackground": "#88440088"
        },
        "tabRow": {
            "background": "#FF8800FF",
            "unfocusedBackground": "#202020FF"
        },
        "window": {
            "applicationTheme": "light",
            "experimental.rainbowFrame": false,
            "frame": null,
            "unfocusedFrame": null,
            "useMica": true
        },
        "pane": {
            "activeBorderColor": "#13A10E",
            "inactiveBorderColor": "#61D6D6"
        }
    }
]

PR Checklist

• Closes Add a setting to manually set the Pane highlight color #3061
• Tests added/passed (None added, can't see how to unit test this but happy to add/dive deeper)
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated (if necessary) -> I have modified to the best of my knowledge

[Techypanda]

@microsoft-github-policy-service agree

[carlos-zamora]

Downloaded the branch and played around with it for a bit. Looks and feels great!

Blocking mainly for the issue where "accent" and "terminalBackground" aren't handled properly.

Also don't forget to update the docs repo please

Thanks!

[Techypanda]

Downloaded the branch and played around with it for a bit. Looks and feels great!

Blocking mainly for the issue where "accent" and "terminalBackground" aren't handled properly.

Fixed in latest push can you retest when available? Thanks

Also don't forget to update the docs repo please

Can update the docs repo, will raise a PR there

[carlos-zamora]

Setting all the pane's border colors to "accent" still doesn't work:

            "pane":
            {
                "activeBorderColor": "accent",
                "inactiveBorderColor": "accent",
                "broadcastBorderColor": "accent"
            },

[carlos-zamora]

I think you don't actually need the variables. In MTSMSettings.h, the last parameter in the macro is nullptr, so if the setting isn't defined, the getter should already retrieve nullptr. You should be able to pass theme.Pane().ActiveBorderColor() and the other ones directly into _updatePaneResources.

[Techypanda]

tested this by removing the pane key from my json and reloading: crashed as theme.Pane() was null; I need the ternary or it goes nullptr.ActiveBorderColor() which crashes it (i could be wrong).

Will try a way that im thinking to clean this up but i dont believe i can pass this directly as you suggest unless im mistaken

[Techypanda]

Found the bug with accent, it was because i wasnt picking accent key sorted that and all 3 being set to accent seems to work
Also found the bug with terminalbackground, swapped to use Evaluate with backgroundBrush as TerminalTab uses (also fed this in and raised where this is used outside the updatePane method).