Skip to content

Use correct Windows SDK path for MakePri.exe #19042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tusharsnx
Copy link
Contributor

@tusharsnx tusharsnx commented Jun 16, 2025

Summary of the Pull Request

The Windows SDK path may not be the same on all PCs, especially when Visual Studio (VS) is installed on a drive other than C:/. However, we can read the correct path from the Registry, which this PR does.

Validation Steps Performed

  1. Install VS on E:/.
  2. Build the solution and see it passes without erroring on accessing MakePri.exe.

@tusharsnx
Copy link
Contributor Author

I realized it's important to mention why this is important: I've a DevDrive at "E:/", and I'm trying to keep all dev related tools and projects on that drive exclusively. Wish C++ tools were smart enough to know where to look, but until then, we'd need to do this ourselves.

@lhecker lhecker requested a review from DHowett June 17, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants