feat(item): enhance update item to handle ItemDisplayNameNotAvailableYet when display name is reserved for 5 min #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badeamarjieh
had a problem deploying
to
development
GitHub Actions
Failure
badeamarjieh
had a problem deploying
to
development
GitHub Actions
Failure
badeamarjieh
had a problem deploying
to
development
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the update item functionality by introducing a retry mechanism to handle cases where an item's display name is reserved (returning the "ItemDisplayNameNotAvailableYet" error). Key changes include replacing direct calls to UpdateItem with RetryUpdateItem across several resource files and adding new retry functions and configurations in helpers.go.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/pkg/fabricitem/resource_item_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/resource_item_definition_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/resource_item_definition.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/resource_item_config_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/resource_item_config_definition_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/resource_item.go | Replaces direct UpdateItem call with RetryUpdateItem |
| internal/pkg/fabricitem/helpers.go | Adds retry logic functions and configuration for handling update errors |
badeamarjieh
commented
Jun 14, 2025
badeamarjieh
had a problem deploying
to
development
GitHub Actions
Failure
badeamarjieh
had a problem deploying
to
development
GitHub Actions
Failure
Minimum allowed line rate is |
1 task
| var respUpdate fabcore.ItemsClientUpdateItemResponse | ||
| var err error | ||
|
|
||
| err = RetryOperation(ctx, DefaultUpdateRetryConfig(), func() error { |
There was a problem hiding this comment.
IMO updating inside of the retry operation is a bit odd,
why not pulling the update to be done before the retry function call, and enter it only if there is an error
There was a problem hiding this comment.
Inside the retry function I'd need to call update again, so that's duplicate code.
There was a problem hiding this comment.
alternatively, I can call the outer function "CreateItem" or "UpdateItem" and the internal implementation can reflect the retry mechanism, WDYT?
…r-fabric into dev/badeamarjieh/handle_name_temporarily_unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
ItemDisplayNameNotAvailableYet