TrxReport keeps all test nodes in memory

[Youssef1313]

We keep a list of TestNodeUpdateMessage in memory for TrxReport to generate the report at the end of the test run.

I wonder if we can write to file stream as we get the info and whether it improves Trx perf.

[nohwnd]

Do you have links to how that is happening? I thought we already write to the file directly, to be more resilient to crash when running the logger in process.

[Youssef1313]

@nohwnd We keep collecting the test nodes in memory here:

testfx/src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs

Line 42 in 8512883

private readonly List<TestNodeUpdateMessage> _tests = [];

Then only in OnTestSessionFinishingAsync we will start do something with them.

testfx/src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs

Lines 229 to 232 in 8512883

	TrxReportEngine trxReportGeneratorEngine = new(_testApplicationModuleInfo, _environment, _commandLineOptionsService, _configuration,
	_clock, [.. _tests], _failedTestsCount, _passedTestsCount, _notExecutedTestsCount, _timeoutTestsCount, _artifactsByExtension,
	_adapterSupportTrxCapability, _testFramework, _testStartTime.Value, exitCode, cancellationToken);
	(string reportFileName, string? warning) = await trxReportGeneratorEngine.GenerateReportAsync().ConfigureAwait(false);

[nohwnd]

👍 thx, I thought it is more clever. It would be nice to experiment with a way to write directly to file, and how performant it would be. Especially if the report needs some closing string.

OR at least we could start by writing a file for the report with a failure, and then collect in memory, and then re-write the file. So we get at least a generic failure result when the process crashes and fails to write anything.