Fix build race condition with MSTest.GlobalConfigsGenerator #5817
+38
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5817 +/- ##
==========================================
+ Coverage 73.08% 73.47% +0.39%
==========================================
Files 608 608
Lines 38370 37277 -1093
==========================================
- Hits 28041 27388 -653
+ Misses 10329 9889 -440
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Youssef1313
changed the title
Youssef1313
changed the title
fhnaseer
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we are not building MSTest.GlobalConfigsGenerator twice in parallel (once by the normal build, and once through
dotnet run). It's then required to ensure GlobalConfigsGenerator is built before MSTest.Analyzers.Package, which is ensured via the slnx change. Then, we need to ensure we use slnx for building (either directly or via slnf).