Allow passing values parameters (#7137)

fix #7118 (Cannot use template parameter in object/array value) 
also fix #5905 (Cannot use template parameter in property default)

Author: timotheeguerin

.chronus/changes/tenative-fix-template-values-2025-3-28-19-41-46.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: feature
+packages:
+  - "@typespec/compiler"
+---
+
+Allow passing template parameters as property defaults

.chronus/changes/tenative-fix-template-values-2025-3-28-19-41-47.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@typespec/compiler"
+---
+
+Allow passing tempalate parameter values in object and array values used inside the template

packages/compiler/src/core/checker.ts

@@ -156,6 +156,7 @@ import {
   UnknownType,
   UsingStatementNode,
   Value,
+  ValueWithTemplate,
   VoidType,
 } from "./types.js";
 
@@ -315,7 +316,7 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     TypeReferenceNode | MemberExpressionNode | IdentifierNode,
     Sym | undefined
   >();
-  const valueExactTypes = new WeakMap<Value, Type>();
+  const valueExactTypes = new WeakMap<ValueWithTemplate, Type>();
   let onCheckerDiagnostic: (diagnostic: Diagnostic) => void = (x: Diagnostic) => {
     program.reportDiagnostic(x);
   };
@@ -561,7 +562,6 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     node: Node,
     mapper?: TypeMapper,
     constraint?: CheckValueConstraint,
-    options: { legacyTupleAndModelCast?: boolean } = {},
   ): Value | null {
     const initial = checkNode(node, mapper, constraint);
     if (initial === null) {
@@ -573,15 +573,28 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     } else {
       entity = initial;
     }
-    // if (options.legacyTupleAndModelCast && entity !== null && isType(entity)) {
-    //   entity = legacy_tryTypeToValueCast(entity, constraint, node);
-    // }
     if (entity === null) {
       return null;
     }
     if (isValue(entity)) {
       return constraint ? inferScalarsFromConstraints(entity, constraint.type) : entity;
     }
+    // If a template parameter that can be a value is used in a template declaration then we allow it but we return null because we don't have an actual value.
+    if (
+      entity.kind === "TemplateParameter" &&
+      entity.constraint?.valueType &&
+      entity.constraint.type === undefined &&
+      mapper === undefined
+    ) {
+      return createValue(
+        {
+          entityKind: "Value",
+          valueKind: "TemplateValue",
+          type: entity.constraint.valueType,
+        },
+        entity.constraint.valueType,
+      ) as any;
+    }
     reportExpectedValue(node, entity);
     return null;
   }
@@ -3841,7 +3854,7 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     );
   }
 
-  function createValue<T extends Value>(value: T, preciseType: Type): T {
+  function createValue<T extends ValueWithTemplate>(value: T, preciseType: Type): T {
     valueExactTypes.set(value, preciseType);
     return value;
   }
@@ -4650,7 +4663,7 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
       pendingResolutions.start(sym, ResolutionKind.Type);
       type.type = getTypeForNode(prop.value, mapper);
       if (prop.default) {
-        const defaultValue = checkDefaultValue(prop.default, type.type);
+        const defaultValue = checkDefaultValue(prop.default, type.type, mapper);
         if (defaultValue !== null) {
           type.defaultValue = defaultValue;
         }
@@ -4687,27 +4700,30 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     };
   }
 
-  function checkDefaultValue(defaultNode: Node, type: Type): Value | null {
+  function checkDefaultValue(
+    defaultNode: Node,
+    type: Type,
+    mapper: TypeMapper | undefined,
+  ): Value | null {
     if (isErrorType(type)) {
       // if the prop type is an error we don't need to validate again.
       return null;
     }
-    const defaultValue = getValueForNode(
-      defaultNode,
-      undefined,
-      {
-        kind: "assignment",
-        type,
-      },
-      { legacyTupleAndModelCast: true },
-    );
+    const defaultValue = getValueForNode(defaultNode, mapper, {
+      kind: "assignment",
+      type,
+    });
     if (defaultValue === null) {
       return null;
     }
     const [related, diagnostics] = relation.isValueOfType(defaultValue, type, defaultNode);
     if (!related) {
       reportCheckerDiagnostics(diagnostics);
       return null;
+    } else if ((defaultValue.valueKind as any) === "TemplateValue") {
+      // Right now we don't want to expose `TemplateValue` in the type graph.
+      // And as interating with the template declaration is not a supported feature we can just drop it.
+      return null;
     } else {
       return { ...defaultValue, type };
     }

packages/compiler/src/core/types.ts

@@ -317,6 +317,9 @@ export type Value =
   | EnumValue
   | NullValue;
 
+/** @internal */
+export type ValueWithTemplate = Value | TemplateValue;
+
 interface BaseValue {
   readonly entityKind: "Value";
   readonly valueKind: string;
@@ -380,6 +383,15 @@ export interface NullValue extends BaseValue {
   value: null;
 }
 
+/**
+ * This is an internal type that represent a value while in a template declaration.
+ * This type should currently never be exposed on the type graph(unlike TemplateParameter).
+ * @internal
+ */
+export interface TemplateValue extends BaseValue {
+  valueKind: "TemplateValue";
+}
+
 //#endregion Values
 
 export interface Scalar extends BaseType, DecoratedType, TemplatedTypeBase {

packages/compiler/test/checker/model.test.ts

@@ -174,6 +174,34 @@ describe("compiler: models", () => {
         deepStrictEqual(foo.defaultValue?.value, "up-value");
       });
     });
+
+    describe("using a template parameter", () => {
+      it(`set it with valid constraint`, async () => {
+        testHost.addTypeSpecFile(
+          "main.tsp",
+          `
+        model A<T extends valueof string> { @test foo?: string = T }
+        alias Test = A<"Abc">;
+        `,
+        );
+        const { foo } = (await testHost.compile("main.tsp")) as { foo: ModelProperty };
+        strictEqual(foo.defaultValue?.valueKind, "StringValue");
+      });
+
+      it(`error if constraint is not compatible with property type`, async () => {
+        testHost.addTypeSpecFile(
+          "main.tsp",
+          `
+        model A<T extends valueof int32> { @test foo?: string = T }
+        `,
+        );
+        const diagnostics = await testHost.diagnose("main.tsp");
+        expectDiagnostics(diagnostics, {
+          code: "unassignable",
+          message: "Type 'int32' is not assignable to type 'string'",
+        });
+      });
+    });
   });
 
   describe("doesn't allow a default of different type than the property type", () => {

packages/compiler/test/checker/templates.test.ts

@@ -1078,4 +1078,61 @@ describe("compiler: templates", () => {
       strictEqual(members[1][1].name, "string");
     });
   });
+
+  describe("template declaration passing values", () => {
+    it("allows passing to a decorator expecting that value", async () => {
+      testHost.addJsFile("effect.js", {
+        $call: () => null,
+      });
+
+      testHost.addTypeSpecFile(
+        "main.tsp",
+        `
+        import "./effect.js";
+        extern dec call(target, arg: valueof string);
+        @call(T) model Dec<T extends valueof string> {}
+        `,
+      );
+      const diagnostics = await testHost.diagnose("main.tsp");
+      expectDiagnosticEmpty(diagnostics);
+    });
+
+    it("allows passing to a decorator expecting a composed value", async () => {
+      testHost.addJsFile("effect.js", {
+        $call: () => null,
+      });
+
+      testHost.addTypeSpecFile(
+        "main.tsp",
+        `
+        import "./effect.js";
+        extern dec call(target, arg: valueof unknown);
+        @call(#{foo: T}) model Dec<T extends valueof string> {}
+        `,
+      );
+      const diagnostics = await testHost.diagnose("main.tsp");
+      expectDiagnosticEmpty(diagnostics);
+    });
+
+    it("validate incompatible composed values", async () => {
+      testHost.addJsFile("effect.js", {
+        $call: () => null,
+      });
+
+      testHost.addTypeSpecFile(
+        "main.tsp",
+        `
+        import "./effect.js";
+        extern dec call(target, arg: valueof {foo: int32});
+        @call(#{foo: T}) model Dec<T extends valueof string> {}
+        `,
+      );
+      const diagnostics = await testHost.diagnose("main.tsp");
+      expectDiagnostics(diagnostics, {
+        code: "invalid-argument",
+        message:
+          "Argument of type '{ foo: string }' is not assignable to parameter of type '{ foo: int32 }'",
+      });
+    });
+  });
 });