incorporating review feedback (simplify createFluentLroWithResponseSyncClientMethods, JavaDoc, var-names)

Author: anuchandy

packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/ClientMethodMapper.java

@@ -609,33 +609,33 @@ private void createFluentLroWithResponseSyncClientMethods(Operation operation, C
 
         final JavaSettings settings = createMethodArgs.settings;
         final boolean isProtocolMethod = createMethodArgs.isProtocolMethod;
-        final MethodOverloadType defaultOverloadType = createMethodArgs.defaultOverloadType;
         final ClientMethodsReturnDescription methodsReturnDescription = createMethodArgs.methodsReturnDescription;
         final ProxyMethod proxyMethod = baseMethod.getProxyMethod();
 
-        final JavaVisibility methodWithContextVisibility;
-        if (settings.isDataPlaneClient()) {
-            methodWithContextVisibility = NOT_VISIBLE;
-        } else {
-            methodWithContextVisibility = methodVisibility(ClientMethodType.SimpleSyncRestResponse, defaultOverloadType,
-                true, isProtocolMethod);
-        }
-
         final IType baseType = ClassType.BINARY_DATA;
         final IType returnType = ResponseTypeFactory.createSyncResponse(operation, baseType, isProtocolMethod, settings,
             proxyMethod.isCustomHeaderIgnored());
         final ReturnValue binaryDataResponse = methodsReturnDescription.createReturnValue(returnType, baseType);
 
-        // Fluent '[Operation]WithResponse' LRO sync method, with required and optional parameters.
-        // Fluent + Sync stack needs simple rest response for implementation only.
+        // Fluent + Sync-Stack needs LRO '[Operation]WithResponse' in implementation scope to enable LRO
+        // 'begin[Operation]'.
+        // Design discussion: https://github.com/Azure/autorest.java/issues/2284
+        //
+        // The sync api corresponding to the below 'withResponseSyncMethod' ClientMethod would look like,
+        //
+        // - private Response<BinaryData> createOrUpdateWithResponse(..)
+        //
+        // such a private api will be used to implement the public LRO 'begin[Operation]' sync method:
+        //
+        // - public SyncPoller<PollResult<Foo>, Foo> beginCreateOrUpdate(..)
         //
         final ClientMethod withResponseSyncMethod = baseMethod.newBuilder()
             .returnValue(binaryDataResponse)
             .name(proxyMethod.getSimpleRestResponseMethodName())
             .onlyRequiredParameters(false)
             .type(ClientMethodType.SimpleSyncRestResponse)
             .groupedParameterRequired(false)
-            .hasWithContextOverload(methodWithContextVisibility != NOT_GENERATE)
+            .hasWithContextOverload(true)
             .proxyMethod(proxyMethod.toSync())
             .methodVisibility(NOT_VISIBLE)
             .build();

packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PollingMetadata.java

@@ -218,19 +218,19 @@ private static PollingMetadata create(LongRunningMetadata lroMetadata, PollingSe
         if (lroMetadata.getPollingStrategy() != null) {
             final String strategyName = lroMetadata.getPollingStrategy().getLanguage().getJava().getName();
             final String strategyFqName = packageName + "." + strategyName;
-            final String syncStrategyFqdnName = packageName + "." + "Sync" + strategyName;
+            final String syncStrategyFqName = packageName + "." + "Sync" + strategyName;
 
             if (lroMetadata.getFinalResultPropertySerializedName() != null) {
                 final String finalResultArg
                     = ClassType.STRING.defaultValueExpression(lroMetadata.getFinalResultPropertySerializedName());
                 pollingStrategy = String.format(PollingSettings.INSTANTIATE_POLLING_STRATEGY_WITH_RESULT_FORMAT,
                     strategyFqName, finalResultArg);
                 syncPollingStrategy = String.format(PollingSettings.INSTANTIATE_POLLING_STRATEGY_WITH_RESULT_FORMAT,
-                    syncStrategyFqdnName, finalResultArg);
+                    syncStrategyFqName, finalResultArg);
             } else {
                 pollingStrategy = String.format(PollingSettings.INSTANTIATE_POLLING_STRATEGY_FORMAT, strategyFqName);
                 syncPollingStrategy
-                    = String.format(PollingSettings.INSTANTIATE_POLLING_STRATEGY_FORMAT, syncStrategyFqdnName);
+                    = String.format(PollingSettings.INSTANTIATE_POLLING_STRATEGY_FORMAT, syncStrategyFqName);
             }
         } else {
             pollingStrategy = pollingSettings.getPollingStrategy();

packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClientMethod.java

@@ -46,13 +46,22 @@ public class ClientMethod {
      */
     private final String name;
     /**
-     * The parameters of this ClientMethod.
+     * An immutable list containing all parameters defined for the operation-endpoint, including constants, client
+     * and method-scoped parameters.
      */
     private final List<ClientMethodParameter> _parameters;
+    /**
+     * A copy of {@code _parameters} returned from the {@link ClientMethod#getParameters()}.
+     */
     private final List<ClientMethodParameter> parameters;
+    /**
+     * The subset of parameters in {@code parameters} that are scoped only to the method.
+     */
     private final List<ClientMethodParameter> methodParameters;
+    /**
+     * The subset of parameters in {@code methodParameters} that are required for the method.
+     */
     private final List<ClientMethodParameter> methodRequiredParameters;
-
     /**
      * Whether this ClientMethod has omitted optional parameters.
      */