-
Notifications
You must be signed in to change notification settings - Fork 284
[http] WIP, merge-patch implementation #7121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] WIP, merge-patch implementation #7121
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes here
|
if (isMutableType(member.type)) { | ||
const variant: UnionVariant = { | ||
...member, | ||
type: mutateSubgraph(program, [self], member.type).type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to apply CreateOrUpdate visibility to variants in the Update case, so feels like the optional mutator should be applied.
} else if ($(realm).record.is(model) && isMutableType(model.indexer!.value)) { | ||
clone.indexer = { | ||
key: model.indexer!.key, | ||
value: mutateSubgraph(program, [self], model.indexer!.value).type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For record types, we also want to apply CreateOrUpdate, so I think the optional mutator, because any key could exist or not in the resource.
Superseded by #7207 |
This work-in-progress PR implements the proposal for JSON merge-patch support in the HTTP core library.
Still to-do: