Skip to content

[python] Update stdio configuration when execute command in child process #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2025

Conversation

msyyc
Copy link
Contributor

@msyyc msyyc commented Apr 27, 2025

According to https://nodejs.org/api/child_process.html#optionsstdio, execSync redirect child's stdin, stdout, and stderr by default so there is no need to configure it.

I tried locally that the change doesn't influence output and error stack.

Copy link
Contributor

github-actions bot commented Apr 27, 2025

All changed packages have been documented.

  • @typespec/http-client-python
Show changes

@typespec/http-client-python - internal ✏️

Update stdio configuration when execute command in child process

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 27, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@msyyc msyyc changed the title [python] Update stdio configuration when execute command in child process [python] Update stdio configuration when execute command in child process (Hold on) Apr 28, 2025
@msyyc
Copy link
Contributor Author

msyyc commented Apr 28, 2025

I hope to hold on this PR. After typespec GA, we could continue.

@msyyc msyyc self-assigned this May 15, 2025
@msyyc msyyc requested a review from timotheeguerin May 15, 2025 08:26
@msyyc msyyc changed the title [python] Update stdio configuration when execute command in child process (Hold on) [python] Update stdio configuration when execute command in child process May 15, 2025
@msyyc msyyc enabled auto-merge May 15, 2025 09:12
@msyyc msyyc added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit c3b4663 May 15, 2025
35 checks passed
@msyyc msyyc deleted the update-stdio branch May 15, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants