Using the ClientMethodMapper extension points and hardening the paging parameter should-hide-check #7337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
anuchandy
changed the title
|
No changes needing a change description found. |
|
You can try these changes here
|
anuchandy
force-pushed
the
reuse-client-method-mapper
branch
2 times, most recently
from
ca10d88 to
c569a08
Compare
anuchandy
commented
May 17, 2025
...soft/typespec/http/client/generator/core/mapper/clientcore/ClientCoreClientMethodMapper.java
Show resolved
Hide resolved
...om/microsoft/typespec/http/client/generator/core/template/ConvenienceMethodTemplateBase.java
Outdated
Show resolved
Hide resolved
...nerator/mgmt/model/clientmodel/fluentmodel/method/CollectionMethodOperationByIdTemplate.java
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Show resolved
Hide resolved
anuchandy
requested review from
srnagar,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
anuchandy
changed the title
anuchandy
commented
May 17, 2025
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Outdated
Show resolved
Hide resolved
...or-core/src/main/java/com/microsoft/typespec/http/client/generator/core/util/MethodUtil.java
Show resolved
Hide resolved
anuchandy
force-pushed
the
reuse-client-method-mapper
branch
from
442145b to
93c563a
Compare
anuchandy
commented
May 18, 2025
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Show resolved
Hide resolved
...nerator/mgmt/model/clientmodel/fluentmodel/method/CollectionMethodOperationByIdTemplate.java
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Outdated
Show resolved
Hide resolved
…alize extraction of continuation and max page size client-method paramaters
…dy of paging methods
anuchandy
force-pushed
the
reuse-client-method-mapper
branch
from
93c563a to
61ace02
Compare
weidongxu-microsoft
approved these changes
May 20, 2025
ArcturusZhang
pushed a commit
to ArcturusZhang/typespec
that referenced
this pull request
May 21, 2025
…g parameter should-hide-check (microsoft#7337) This PR has the following changes - 1. Taking advantages of refactoring done in [microsoft#7015](microsoft#7015) for `ClientMethodMapper` there by deleting the additional code we no longer needed. 2. Centralizing the derivation and lookup of paging parameters to `PagingMetadata` and `MethodPageDetails `. 3. Removing relaxed paging parameter lookup instead using common strict lookup in all places (azure, client-core etc..). The AutoRest CI run is [green](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4878954&view=results) with this PR's last commit [80bf3a9].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes -
ClientMethodMapperthere by deleting the additional code we no longer needed.PagingMetadataandMethodPageDetails.The AutoRest CI run is green with this PR's last commit [80bf3a9].