Skip to content

[WIP]: Updating ClientCoreClientMethodTemplate to reuse functionalities from base ClientMethodTemplate #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anuchandy
Copy link
Member

@anuchandy anuchandy commented May 29, 2025

The pr update "ClientCoreClientMethodTemplate" to reuse addValidation, addOptionalAndConstantVariables, addOptionalAndConstantVariablesand convertClientTypesToWireTypes methods from "ClientMethodTemplate".

@anuchandy anuchandy self-assigned this May 29, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label May 29, 2025
Copy link
Contributor

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 29, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@anuchandy anuchandy force-pushed the clientMethodTemplate-cleanup-1 branch from 6ca9a27 to 1b9030b Compare May 29, 2025 23:14
@anuchandy anuchandy marked this pull request as draft May 30, 2025 00:35
@anuchandy anuchandy changed the title Updating ClientCoreClientMethodTemplate to reuse functionalities from base ClientMethodTemplate [WIP]: Updating ClientCoreClientMethodTemplate to reuse functionalities from base ClientMethodTemplate May 30, 2025
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants