Add OmitMetadata, StripMetadata and pass metadata properties through in MergePatch
#7551
Conversation
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
timotheeguerin
requested review from
bterlson,
markcowl,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
| * ``` | ||
| */ | ||
| @Private.omitMetadata(T, NameTemplate) | ||
| model OmitMetadata<T extends Reflection.Model, NameTemplate extends valueof string = ""> {} |
There was a problem hiding this comment.
I feel like we should have a filtering mechanism here, where the choices are, at least 'requestMetadata' 'responseMetadata' and 'all'
There was a problem hiding this comment.
Although, I think 'all' is the right default, so maybe we can leave this until additional flexibility is asked for
There was a problem hiding this comment.
yeah just not sure what exactly we should allow to filter. I think it for example make sense to filter per type as well "query"
| @@ -67,6 +87,8 @@ export type TypeSpecHttpPrivateDecorators = { | |||
| httpFile: HttpFileDecorator; | |||
| httpPart: HttpPartDecorator; | |||
| applyMergePatch: ApplyMergePatchDecorator; | |||
| omitMetadata: OmitMetadataDecorator; | |||
| stripMetadata: StripMetadataDecorator; | |||
There was a problem hiding this comment.
Hmm, not sure about 'stripMetadata' I wonder if we should be more explicit, as in 'RemoveMetadataProperties' and 'RemoveMetadataDecorators'
There was a problem hiding this comment.
Note that it would also be nice to have a PickMetadataProperties or the like that returns only the metadata properties, but this is not as important as the other two.
There was a problem hiding this comment.
that one I think is a bit more tricky with nested metadata. Does it flatten it or keep the structure and then what does that mean for the envelope does it need to add @bodyIgnore on it?
Progress for #7279