[typespec-vscode] Allow lsp disable running emitters #7576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
RodgeFu,
bterlson,
markcowl,
timotheeguerin,
chrisradek,
AlitzelMendez,
lirenhe and
witemple-msft
as code owners
|
You can try these changes here
|
RodgeFu
reviewed
Jun 10, 2025
RodgeFu
reviewed
Jun 10, 2025
RodgeFu
reviewed
Jun 10, 2025
RodgeFu
reviewed
Jun 10, 2025
RodgeFu
reviewed
Jun 11, 2025
RodgeFu
reviewed
Jun 11, 2025
|
@timotheeguerin please help review |
| createClientConfigProvider, | ||
| } from "../../src/server/client-config-provider.js"; | ||
|
|
||
| describe("compiler: server: client-config-provider", () => { |
There was a problem hiding this comment.
remove top level describe
| "typespec.lsp.emit": { | ||
| "type": "array", | ||
| "default": null, | ||
| "description": "List of emitters that should be included in compilation in typespec LSP server when supporting LSP related functionalities.\n\nExample:\n\"typespec.lsp.emit\": [\n \"@typespec/openapi3\"\n]", |
There was a problem hiding this comment.
Should describe that this will just run the emitter in dry mode for emitters that support it even if you enable it
| * @param defaultValue Default value if not found | ||
| * @returns The configuration value or default | ||
| */ | ||
| get<T>(section: string): T | undefined; |
There was a problem hiding this comment.
Any reason to not have the known config itself be typed instead of having this be done at the point of usage?
| // If emit is set in additionalOptions, use this setting first | ||
| // otherwise, obtain the `typespec.lsp.emit` configuration from clientConfigsProvider | ||
| if (additionalOptions?.emit === undefined) { | ||
| const configEmits = clientConfigsProvider?.get<string[]>("typespec.lsp.emit"); |
There was a problem hiding this comment.
clientConfigsProvider?.config?.lsp?.emit
I think would be a simpler experience
| - typespec-vscode | ||
| --- | ||
|
|
||
| Allow LSP to run emitters configured by users in the settings |
There was a problem hiding this comment.
Suggested change
| Allow LSP to run emitters configured by users in the settings | |
| Allow LSP to configure which emitters to include for live checks |
|
|
||
| // Verify configuration was fetched and applied | ||
| strictEqual(mockConnection.workspace.getConfiguration.mock.calls.length, 1); | ||
| strictEqual(mockConnection.workspace.getConfiguration.mock.calls[0]?.[0], "typespec"); |
There was a problem hiding this comment.
you can use instead expect().toHaveBeenCalled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix： #7305
Allow lsp disable running emitters