Add test case for extension resource in ArmResourceTest #7597
+415
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
v-hongli1
requested review from
srnagar,
anuchandy,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
...ttp-client-generator-test/src/test/java/azure/resourcemanager/resources/ArmResourceTest.java
Outdated
Show resolved
Hide resolved
v-hongli1
force-pushed
the
AddExtensionResourceTests
branch
from
7507624 to
4252949
Compare
Comment on lines
+62
to
+67
| private ExtensionsResourceProperties createProperties | ||
| = new ExtensionsResourceProperties().withDescription(RESOURCE_DESCRIPTION_VALID); | ||
| private ExtensionsResourceProperties updateProperties | ||
| = new ExtensionsResourceProperties().withDescription(RESOURCE_DESCRIPTION_VALID2); | ||
| private ExtensionsResource extensionResource; | ||
| private List<ExtensionsResource> extensionResources; |
There was a problem hiding this comment.
They are mutable, so it should be defined in each test.
You can have private static final of the 2 CREATE_PROPERTIES and UPDATE_PROPERTIES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case for extension resource in
ArmResourceTest.