Skip to content

ClientCore - generate only max overloads in client implementation #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2025

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Jun 10, 2025

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Jun 10, 2025
Copy link
Contributor

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 10, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srnagar srnagar marked this pull request as ready for review June 11, 2025 01:00
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we considered filtering this in ClientMethodMapper, instead of in Template?

@srnagar srnagar enabled auto-merge June 12, 2025 23:18
@srnagar srnagar added this pull request to the merge queue Jun 13, 2025
Merged via the queue into microsoft:main with commit 790f0e2 Jun 13, 2025
25 checks passed
@srnagar srnagar deleted the impl-overloads branch June 13, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants