Improvement: In emitter:server:csharp add CancellationToken to method definition as it is common in ASP.NET APIs #7617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in ASP.NET APIs
GonanRdg
changed the title
GonanRdg
requested review from
bterlson,
markcowl,
timotheeguerin,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add CancellationToken to emitter:server:csharp in method definitions
Why?
All methods created by default by the ASP.NET Web APIs include Cancellation tokens as the last parameter.
How?
Add the correct token in the c# code template