java v2: client wrapper instrumentation #7638
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
srnagar,
anuchandy,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
| @@ -115,6 +116,7 @@ public class ClientMethod { | |||
| private final boolean hasWithContextOverload; | |||
| private final String parametersDeclaration; | |||
| private final String argumentList; | |||
| private final Operation operation; | |||
There was a problem hiding this comment.
We should not set the Operation object into the ClientMethod. It creates too much coupling.
If you really have to, you can put something like String methodInstructionId that capture your current value.
Also, I am not sure about the intention of
String operationName
= String.format("%s.%s", operation.getOperationGroup().getLanguage().getDefault().getName(),
operation.getLanguage().getDefault().getName());
As you can see, lots of regenerated code now looks like this
return this.instrumentation.instrumentWithResponse(".valid", requestContext,
I am not sure whether the .valid is a good name.
The name in operationGroup may not be what was in Swagger. TypeSpec would have client.tsp to rearrange the operation groups, and here the name would have no relation to what in their REST API doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.