Skip to content

[http-client-csharp] add operators for collection types #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

jorgerangel-msft
Copy link
Contributor

@jorgerangel-msft jorgerangel-msft commented Jun 16, 2025

This PR fixes a regression where responses that were collection types of models did not have their operators generated.

contributes to: #7628

@jorgerangel-msft jorgerangel-msft changed the title fix: add operators for collection types [http-client-csharp] add operators for collection types Jun 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jun 16, 2025
Copy link
Contributor

No changes needing a change description found.

@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review June 16, 2025 15:31
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Jun 16, 2025
Merged via the queue into microsoft:main with commit 00a8044 Jun 16, 2025
21 checks passed
@jorgerangel-msft jorgerangel-msft deleted the fix-operators branch June 16, 2025 17:01
JoshLove-msft added a commit that referenced this pull request Jun 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 18, 2025
Reverts #7646

We don't really need the explicit operators for collection types as the
ClientResult will have multiple elements so casting to the type won't
work. We can add these by hand for the OAI use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants