Not planned
Description
Steps to reproduce:
- Open a PR on a repo which is from a fork, it then looks like this:
- Copy this
- Paste it here:
Expected:
If I use mxschmitt:foobar it does match the local branch name foobar.
Actual:
It does not match any item from the list since it tries to match mxschmitt:foobar against the local available branches.
Motivation: I think everything on the left side of the colon (:) can be thrown away and only the right part can be considered as part of a fallback matching logic.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
vscodenpa commentedon Dec 16, 2023
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!
mxschmitt commentedon Dec 20, 2023
Turns out
:is not an allowed characters inside branch names, so doing it should not have any other side effects.I tried looking into it: The challenge will be that the matching behaviour can't be influenced via the public Extension API, since it uses the public available QuickPick element as per here.
So I thought about two options, not happy about any of these, maybe @lszomoru you have a better idea.
a) When the user pastes it in, we can just cut of the left part of the colon, but this seems to be an unexpected UX behavior
b) Maybe we can influence the matching logic of the QuickPick without exposing it publicly?
Looks like there is already an option called
filterValuefor it, its just not exposed to the extension host.vscodenpa commentedon Feb 5, 2024
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!
vscodenpa commentedon Feb 16, 2024
🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!