Skip to content

Should fontfeatureSettings be exposed to webviews #243202

Closed
@a-stewart

Description

@a-stewart
Contributor

Sometimes in Webviews you want to reproduce the style of editor text.

There is --vscode-editor-font-family, --vscode-editor-font-weight and --vscode-editor-font-size available. As well as foregound and background.

One thing that doesn't exist though is a simple way to honour the users ligature preferences.

It looks like you might be able to use --vscode-editorCodeLens-fontFeatureSettings

Should we expose something like --vscode-editor-fontFeatureSettings to webviews, or is it correct that webviews should use the code lens property instead?

Edit: looks like --vscode-editorCodeLens-fontFeatureSettings is not available in Webviews either.

Activity

mjbvz

mjbvz commented on Mar 11, 2025

@mjbvz
Collaborator

I think vscode-editorCodeLens-fontFeatureSettings is internal only but we could expose the editor.fontLigatures setting if there's interest

You can already use it in webviews by reading the setting value in the extension and sending it to the webview. Adding a proper css variable just makes it easier to use

Marking as help wanted

added
help wantedIssues identified as good community contribution opportunities
webviewWebview issues
on Mar 11, 2025
added this to the June 2025 milestone on Jun 9, 2025
added
unreleasedPatch has not yet been released in VS Code Insiders
insiders-releasedPatch has been released in VS Code Insiders
and removed
unreleasedPatch has not yet been released in VS Code Insiders
on Jul 1, 2025
a-stewart

a-stewart commented on Jul 2, 2025

@a-stewart
ContributorAuthor

Thanks!

vs-code-engineering

vs-code-engineering commented on Jul 2, 2025

@vs-code-engineering

This bug has been fixed in the latest release of VS Code Insiders!

@a-stewart, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 6e85500 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

a-stewart

a-stewart commented on Jul 3, 2025

@a-stewart
ContributorAuthor

/verified

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedverifiedVerification succeededwebviewWebview issues

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @a-stewart@connor4312@mjbvz@osortega

    Issue actions

      Should fontfeatureSettings be exposed to webviews · Issue #243202 · microsoft/vscode