Skip to content

Allow ThemeIcon in WebviewPanel.iconPath #90616

New issue
New issue
Open
#92122
Open
Allow ThemeIcon in WebviewPanel.iconPath#90616
#92122
Assignees
mjbvz
Labels
apifeature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesicons-productIssues for in-product iconswebviewWebview issues
Milestone
 
Backlog
@ridiculous-thought

Description

@ridiculous-thought
ridiculous-thought
opened on Feb 13, 2020

Issue Type: Feature Request

You can only pass an Uri or an object containing Uris to WebviewPanel.iconPath, while iconPath on QuickInputButton and TreeItem also supports ThemeIcon. This would increase codicon reusability.

VS Code version: Code 1.42.0 (ae08d54, 2020-02-06T10:51:34.058Z)
OS version: Windows_NT x64 10.0.18362

Activity

JacksonKearl
assigned
mjbvz
on Feb 13, 2020
mjbvz
added
api
webviewWebview issues
on Feb 13, 2020
mjbvz
added this to the Backlog milestone on Mar 5, 2020
mjbvz
added
feature-requestRequest for new features or functionality
on Mar 5, 2020
mjbvz
assigned
miguelsolorio
on Mar 5, 2020
mjbvz

mjbvz commented on Mar 5, 2020

@mjbvz
mjbvz
on Mar 5, 2020
Collaborator

@bpasero I believe we should change how editors get their icons to support this. My proposal is to add a IEditorInput.icon property that lets editor inputs set their icon directly instead of going through css rules based on the resource. This could also be used for our welcome page and a few other places in VS Code core that have to use css for this today:

vscode/src/vs/workbench/contrib/welcome/page/browser/welcomePage.css

Line 223 in ceb8d83

background-image: url('../../code-icon.svg');

mjbvz
assigned
bpasero
on Mar 5, 2020
mjbvz
linked a pull request that will close this issue on Mar 5, 2020
bpasero

bpasero commented on Mar 6, 2020

@bpasero
bpasero
on Mar 6, 2020
Member

Works for me.

bpasero
added
workbench-editorsManaging of editor widgets in workbench window
on Mar 6, 2020
bpasero
removed their assignment
on Apr 14, 2020
mjbvz
mentioned this on Apr 27, 2020

28 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apifeature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesicons-productIssues for in-product iconswebviewWebview issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    Participants

    @bpasero@aeschli@mjbvz@daviddossett@miguelsolorio

    Issue actions
      Allow ThemeIcon in WebviewPanel.iconPath · Issue #90616 · microsoft/vscode