Skip to content

Update imports for all files #105111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update imports for all files #105111

wants to merge 1 commit into from

Conversation

9at8
Copy link
Contributor

@9at8 9at8 commented Aug 20, 2020

This PR fixes #105110

@mjbvz I don't know why, but sometimes these changes cause some weird things:

  • "ghost files" are created - after the import is updated, a duplicate of the old file might be present
  • all imports are not updated

I can't reliably repro any of these, any tips would be appreciated 😄

@ghost
Copy link

ghost commented Aug 20, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@9at8
Copy link
Contributor Author

9at8 commented Aug 31, 2020

@mjbvz can you take a look? 👀

@mjbvz mjbvz added this to the September 2020 milestone Sep 15, 2020
@mjbvz mjbvz modified the milestones: September 2020, October 2020 Oct 2, 2020
@mjbvz mjbvz modified the milestones: October 2020, November 2020 Oct 30, 2020
@mjbvz mjbvz modified the milestones: January 2021, February 2021 Jan 29, 2021
@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@jrieken jrieken modified the milestones: February 2021, March 2021 Mar 1, 2021
@mjbvz mjbvz modified the milestones: March 2021, April 2021 Mar 24, 2021
@mjbvz mjbvz modified the milestones: April 2021, May 2021 Apr 29, 2021
@mjbvz mjbvz modified the milestones: May 2021, Backlog Jun 1, 2021
@DanKaplanSES DanKaplanSES mentioned this pull request Jan 11, 2022
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2022

Sorry keep pushing this off as based on the comments it seems this was not ready to merge and required more investigation

@zen-crab
Copy link
Contributor

This issue was resolved in PR #191403

Imran-imtiaz48

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Imran-imtiaz48 Imran-imtiaz48 Imran-imtiaz48 left review comments

@crypt096 crypt096 crypt096 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Imports are not updated if multiple files are moved
6 participants
@9at8 @mjbvz @zen-crab @crypt096 @Imran-imtiaz48 @jrieken