Skip to content

Add transition to window buttons #116078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chaitunya
Copy link

@chaitunya chaitunya commented Feb 8, 2021

This PR fixes #116076. It adds a 0.25-second-long transition to the window buttons for the Windows custom titlebar:

after.mp4

JKrol
JKrol previously approved these changes Feb 8, 2021
@bpasero bpasero assigned sbatten and unassigned bpasero Feb 9, 2021
@sbatten
Copy link
Member

sbatten commented Feb 9, 2021

@chaitunya in my testing, windows apps are not consistent about this. In fact, most store apps I have installed use no animation. Others use an animation but only to fade the red, not to activate it.

@chaitunya
Copy link
Author

@sbatten I've also noticed that Windows apps aren't consistent about it, which is why I'm making this contribution.

I've done some testing with a screen recorder and slowing down the video, and realized that when activating, the transition length is 0.075s and when deactivating, the transition length is 0.15s. Should I switch the transition length to these values?

@sbatten
Copy link
Member

sbatten commented Feb 10, 2021

@chaitunya yes please, which app are you basing this on in your video? It seems like it might be the new Edge, which would be my preference as well.

@chaitunya
Copy link
Author

@sbatten I had originally tested File Explorer kind of hastily.

I had too much time on my hands today, so I just recorded Edge and slowed it down 60x, so each frame was one second.

Window.buttons.mp4

As you can see, the activation was 8 frames long and the deactivation was 13 frames long, so the timings should be about 0.13 seconds and 0.22 seconds, respectively.

@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transition to window buttons
4 participants