Fix some code issues in PieceTree impl #120172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@komonad thanks for your contribution! A set of test cases to cover the changes will be much appreciated. |
komonad
force-pushed
the
piecetree
branch
3 times, most recently
from
1023a3d to
1f30413
Compare
- add some test cases for changed code
|
I'm not sure if the test cases should be implemented like this (the parts I've changed are basically internal APIs), but I add them anyway. I guess I'll need some reviews or suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some naming issues and duplication in the Red-Black Tree implementation. And it replaces some recursion with iteration in some help functions.