Skip to content

Update merge-conflict extension #128662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inb4after
Copy link

@inb4after inb4after commented Jul 14, 2021

Inspired by Atom's options to resolve merge conflicts: "Resolve as Ours then Theirs" and "Resolve as Theirs then Ours"

-Remove "Accept Both" options when resolving merge conflicts
-Add options to resolve conflicts as "Both Changes", in both orders

This allows for greater granular control over the order of the code applied, in cases where incoming changes need to come before existing changes for functionality or prettification.

P.S: Had some trouble testing the extension with vsce, as it comes pre-packaged with vscode, so for now it remains untested.

Code changes are minimal and shouldn't break anything. Hopefully someone can point out how to test this out (if there's an easier way than building vscode entirely!)

I openly welcome any reviews, changes and improvements as this is my first time working with ts!

Remove "Accept Both" options when resolving merge conflicts
Add options to resolve conflicts as both changes, in any order
@ghost
Copy link

ghost commented Jul 14, 2021

CLA assistant check
All CLA requirements met.

@lszomoru lszomoru assigned lszomoru and unassigned eamodio Oct 4, 2021
@joaomoreno joaomoreno assigned chrmarti and unassigned lszomoru May 2, 2022
@joaomoreno joaomoreno added the merge-conflict Merge conflict decorations and actions label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict Merge conflict decorations and actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants