Add prompt to issue reporter asking users to test on insiders build before submitting report #138881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Wang <daviwang@umich.edu>
|
Just a heads up. Things slow down during the holidays. I'll try to get to this as soon as I can, but please have patience with me 🙏 |
p4nu
suggested changes
Jun 4, 2022
| @@ -759,7 +759,7 @@ export class IssueReporter extends Disposable { | |||
| } | |||
|
|
|||
| reset(descriptionTitle, localize('stepsToReproduce', "Steps to Reproduce"), $('span.required-input', undefined, '*')); | |||
| reset(descriptionSubtitle, localize('performanceIssueDesciption', "When did this performance issue happen? Does it occur on startup or after a specific series of actions? We support GitHub-flavored Markdown. You will be able to edit your issue and add screenshots when we preview it on GitHub.")); | |||
| reset(descriptionSubtitle, localize('performanceIssueDesciption', "When did this performance issue happen ? Does it occur on startup or after a specific series of actions? We support GitHub-flavored Markdown.You will be able to edit your issue and add screenshots when we preview it on GitHub.")); | |||
There was a problem hiding this comment.
Suggested change
| reset(descriptionSubtitle, localize('performanceIssueDesciption', "When did this performance issue happen ? Does it occur on startup or after a specific series of actions? We support GitHub-flavored Markdown.You will be able to edit your issue and add screenshots when we preview it on GitHub.")); | |
| reset(descriptionSubtitle, localize('performanceIssueDesciption', "When did this performance issue happen? Does it occur on startup or after a specific series of actions? We support GitHub-flavored Markdown. You will be able to edit your issue and add screenshots when we preview it on GitHub.")); |
| @@ -740,7 +740,7 @@ export class IssueReporter extends Disposable { | |||
| show(extensionsBlock); | |||
| } | |||
| reset(descriptionTitle, localize('stepsToReproduce', "Steps to Reproduce"), $('span.required-input', undefined, '*')); | |||
| reset(descriptionSubtitle, localize('bugDescription', "Share the steps needed to reliably reproduce the problem. Please include actual and expected results. We support GitHub-flavored Markdown. You will be able to edit your issue and add screenshots when we preview it on GitHub.")); | |||
| reset(descriptionSubtitle, localize('bugDescription', "Share the steps needed to reliably reproduce the problem.Please include actual and expected results.We support GitHub - flavored Markdown.You will be able to edit your issue and add screenshots when we preview it on GitHub. {0}", this.issueReporterModel.getData().versionInfo.vscodeVersion.includes('insiders') ? '' : 'Please ensure that this issue hasn\'t already been resolved on an insiders build before submitting.')); | |||
There was a problem hiding this comment.
This will break the current translation. Also check that spaces are like in the original text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #52210
This PR adds text to the "Steps to Reproduce" section of the issue reporter asking the user to test on an insiders build before submitting the report. This PR also detects the build the user is running and decides whether to display the text or not based on that information.
To test, you can change the version in package.json. Tacking "-insiders" to the end of it indicates an insiders build, and will flip whether or not the text shows.