Skip to content

Use Separate Options Configuration for Find (CMD+F, CTRL+F) and Selection Match (CMD+D, CTRL+D) #140782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DoctorPoor
Copy link

@DoctorPoor DoctorPoor commented Jan 15, 2022

Issue

issue.mov

Desired Behaviour

  • Allow the user to configure Find and Selection Match options independently

Changelog

  • Made Selection Match (CMD+D, CTRL+D) use different options configuration than Find (CMD+F, CTRL+F)
changelog.mov

@ghost
Copy link

ghost commented Jan 15, 2022

CLA assistant check
All CLA requirements met.

@alexdima
Copy link
Member

I think the main use-case of cmd+d / ctrl+d is handled when starting with a collapsed selection. The very first cmd+d / ctrl+d will expand to the word and temporarily dissociate the whole word and match case settings and turn them on. When starting cmd+d / ctrl+d with an existing selection, then the whole word and match case settings will be connected to the find widget ones. I think the proposed solution is fair, but it suffers from the problem that the whole word / match case settings can't be clicked on / rendered when the find widget is shown. I will close for now, if you continue to feel very strongly about this, we can try reviving the PR behind an opt-in setting.

@alexdima alexdima closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+D should match whole words instead of substrings
2 participants