Allow text change events to report their source #150966 #150967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Oct 3, 2022
| * Optional identifier of the top-most intent that triggered this event e.g. all editing operations | ||
| * triggered by user pasting text from clipboard will have "paste" source. | ||
| */ | ||
| readonly source?: string | undefined; |
There was a problem hiding this comment.
We don't accept direct changes to the API, they must go through a proposal-process in which they are examined and discussed. See https://github.com/Microsoft/vscode/wiki/Extension-API-process for details.
For this particular case I see a conflict with TextDocumentChangeReason a few lines above. I believe it serves a similar/same intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #150966
Tested by listening to vscode.workspace.onDidChangeTextDocument and checking event.source, then pasting something into the editor.