Skip to content

Fix 152790 : Invalid regex message obscures search #153013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

omkarshinge
Copy link

@omkarshinge omkarshinge commented Jun 23, 2022

This PR fixes #152790 : Invalid regex message obscures search

Root cause of bug :

  • The error message was getting displayed even before the find/search widget takes place after transition/animation which resulted in improper positioning of the error message.

Change done :

  • Increased the timeout set for validation from 200ms to 300ms [ file : findWidget.ts ]

Tests performed on UI :

  • Checked the reopening of find widget with invalid regex on editor using Ctrl + F key combination [Ctrl+F, invalid regex, Esc, Ctrl+F again as mentioned in bug]
  • Checked the find widget on editor using Ctrl + F and Ctrl + V key combination used rapidly with invalid regex

Working behavior after fix :

  • The error message gets aligned properly below the find widget.

Test machine details :
Version: 1.69.0
Electron: 18.3.4
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Linux x64 5.10.0-14-amd64

@omkarshinge omkarshinge changed the title Fix 152790 Fix 152790 : Invalid regex message obscures search Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid regex message obscures search
2 participants